[Bug 256268] [NEW PORT] sysutils/py-concurrent-log-handler: RotatingFileHandler replacement with concurrency, gzip and Windows support

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256268

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|New |Open
Keywords| |feature, needs-qa
CC| |***@FreeBSD.org

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256268

risner <***@stdio.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #225380|0 |1
is obsolete| |

--- Comment #1 from risner <***@stdio.com> ---
Created attachment 225404
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=225404&action=edit
Updated file

Ran through portlint and resolved issues.
New git staged diff.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256268

risner <***@stdio.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #225404|0 |1
is obsolete| |

--- Comment #2 from risner <***@stdio.com> ---
Created attachment 225422
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=225422&action=edit
Final staged git diff.

More cleanup and fixed incorrect license.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256268

risner <***@stdio.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Severity|Affects Only Me |Affects Some People

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256268

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Severity|Affects Some People |Affects Only Me
Summary|[NEW PORT] |[NEW PORT]
|sysutils/py-concurrent-log- |sysutils/py-concurrent-log-
|handler: |handler:
|RotatingFileHandler |RotatingFileHandler
|replacement with |replacement with
|concurrency, gzip and |concurrency, gzip
|Windows support |

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256268

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Flags| |maintainer-feedback?(risner
| |@stdio.com)
Keywords| |needs-patch
CC| |***@stdio.com

--- Comment #3 from Kubilay Kocak <***@FreeBSD.org> ---
Review items:

- Add LICENSE_FILE when a license file file is provided in the distribution
file(s).
- setup.py declares dependencies not references in port:

install_requires = [
'portalocker<=1.7.1; python_version < "3"',
'portalocker>=1.4.0; python_version >= "3"',
]

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256268

risner <***@stdio.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #225422|0 |1
is obsolete| |

--- Comment #4 from risner <***@stdio.com> ---
Created attachment 225486
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=225486&action=edit
FIxed issues

Obsoleted the old patch, updated with the license file and the missing dep.

Thanks

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256268

risner <***@stdio.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #225486|0 |1
is obsolete| |

--- Comment #5 from risner <***@stdio.com> ---
Created attachment 225487
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=225487&action=edit
Typo in required versions. Fixed.

Take 2

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256268

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Keywords|needs-patch, needs-qa |
Flags|maintainer-feedback?(risner |maintainer-feedback+
|@stdio.com) |

--- Comment #6 from Kubilay Kocak <***@FreeBSD.org> ---
Only other thing (for future reference), is when producing patches, generate
them against the ports root, so the category/path is available

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256268

--- Comment #7 from risner <***@stdio.com> ---
Acknowledged. Thanks.