[Bug 256272] www/py-graphite-web: Skipped w/py39 due to sysutils/py-scandir incompatibility

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256272

John W. O'Brien <***@saltant.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@FreeBSD.org

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256272

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Severity|Affects Only Me |Affects Some People
Summary|www/py-graphite-web: |sysutils/py-scandir: Fails
|Skipped w/py39 due to |to stage on Python 3.9:
|sysutils/py-scandir |error: redefinition of
|incompatibility |'PyStructSequence_UnnamedFi
| |eld' with a different type:
| |'char *' vs 'const char
| |*const' (breaks
| |www/py-graphite-web)
Assignee|ports-***@FreeBSD.org |***@FreeBSD.org
Status|New |Open
Keywords| |needs-qa
CC| |***@saltant.com
Flags| |maintainer-feedback?(***@s
| |altant.com),
| |maintainer-feedback?(sunpoe
| |***@FreeBSD.org),
| |merge-quarterly?

--- Comment #1 from Kubilay Kocak <***@FreeBSD.org> ---
@John If the code doesn't import from the standard library, the upstream code
will need to be modified, and should be resolved upstream (as a pr/commit).

Can you detail the situation with respect to this? We can update summary to
reflect the root cause/resolution once identified.

Also, is quarterly affected, and any other Python versions?

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256272

John W. O'Brien <***@saltant.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |ports-***@FreeBSD.org
Attachment #225411| |maintainer-approval?(ports-
Flags| |***@FreeBSD.org)

--- Comment #2 from John W. O'Brien <***@saltant.com> ---
Created attachment 225411
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=225411&action=edit
www/py-graphite-web: Drop dependency on sysutils/py-scandir

Based on static analysis, I conclude that www/py-graphite-web supports scandir
from the standard library and will preferentially use it when it is available.
Therefore, the port can unconditionally drop the dependency because it is
already limited to Python 3.5 and newer. I have reported a bug [0] and proposed
a patch [1] upstream.

sysutils/scandir should be limited to python:3.6-3.8

[0] https://github.com/graphite-project/graphite-web/issues/2705
[1] https://github.com/graphite-project/graphite-web/pull/2706

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256272

--- Comment #3 from John W. O'Brien <***@saltant.com> ---
It's not clear what I would be indicating by setting the maintainer feedback
flag one way or the other, but I believe my intentions are clear, so I will
leave it to those who care about such things to handle it however they see fit.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256272

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Keywords|needs-qa |
Flags|maintainer-feedback?(***@s |maintainer-feedback+
|altant.com) |
See Also| |https://github.com/graphite
| |-project/graphite-web/pull/
| |2706,
| |https://github.com/graphite
| |-project/graphite-web/issue
| |s/2705

--- Comment #4 from Kubilay Kocak <***@FreeBSD.org> ---
(In reply to John W. O'Brien from comment #2)

Thanks for the clarity John