maintainer-feedback requested: [Bug 255025] textproc/py-chardet: Update to 4.0.0

[b***@freebsd.org]

Bugzilla Automation <***@FreeBSD.org> has asked freebsd-python (Nobody)
<***@FreeBSD.org> for maintainer-feedback:
Bug 255025: textproc/py-chardet: Update to 4.0.0
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255025

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255025

--- Comment #1 from commit-***@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/ports/commit/?id=cbb8e36106080a07bcedff674c1ee411b70aef35

commit cbb8e36106080a07bcedff674c1ee411b70aef35
Author: Wen Heping <***@FreeBSD.org>
AuthorDate: 2021-06-01 10:11:21 +0000
Commit: Wen Heping <***@FreeBSD.org>
CommitDate: 2021-06-01 10:11:21 +0000

textproc/py-chardet: Update to 4.0.0

PR: 255025
Submitted by: ***@airport.fm

textproc/py-chardet/Makefile | 3 +--
textproc/py-chardet/distinfo | 6 +++---
textproc/py-chardet/files/patch-test.py (gone) | 16 ----------------
3 files changed, 4 insertions(+), 21 deletions(-)

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255025

Wen Heping <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@FreeBSD.org
Resolution|--- |FIXED
Status|New |Closed

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255025

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.freebsd.org/bu
| |gzilla/show_bug.cgi?id=2562
| |19

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255025

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|***@FreeBSD.org |***@FreeBSD.org
Resolution|FIXED |---
Status|Closed |In Progress
CC| |***@FreeBSD.org

--- Comment #2 from Kubilay Kocak <***@FreeBSD.org> ---
^Triage: Assign to committer that resolved

@Wen At least one port (py-aiohttp)declares a version-spec for chardet <4.0

This update breaks that port and its dependents

What testing was run for this change?

https://github.com/freebsd/freebsd-ports/blob/main/www/py-aiohttp/Makefile#L17

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255025

--- Comment #3 from Wen Heping <***@FreeBSD.org> ---
(In reply to Kubilay Kocak from comment #2)
Sorry the commit break www/py-aiohttp.

Hope PR/256219 would be committed soon. if not, I would revert this commit.

wen

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255025

--- Comment #4 from Kubilay Kocak <***@FreeBSD.org> ---
(In reply to Wen Heping from comment #3)

Note that aiohttp may not be the only port impacted

Re aiohttp though, given the fallout, if you can QA bug 256219 in short order,
and I provided review in 256219#c4 you are free to land that change. That fixes
that, however...

If confirming no other ports are not affected cant be done in short order, I'd
probably revert the change.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255025

--- Comment #5 from Wen Heping <***@FreeBSD.org> ---
(In reply to Kubilay Kocak from comment #4)
I would check all the ports depends on py-chardet now.

wen

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255025

--- Comment #6 from Wen Heping <***@FreeBSD.org> ---
www/py-httpx013 require textproc/py-chardet<4,
I would suggest create textproc/py-chardet3 to keep www/py-httpx013 build.

How about it ?

wen

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255025

--- Comment #7 from Kubilay Kocak <***@FreeBSD.org> ---
(In reply to Wen Heping from comment #6)

Your call Wen.