maintainer-feedback requested: [Bug 256141] lang/python38: Fails to install without LIBFFI

[b***@freebsd.org]

Bugzilla Automation <***@FreeBSD.org> has asked freebsd-python (Nobody)
<***@FreeBSD.org> for maintainer-feedback:
Bug 256141: lang/python38: Fails to install without LIBFFI
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256141



--- Description ---
When building lang/python38 without LIBFFI option (Use libffi from ports
instead of bundled version) it fails to install:

===> Installing for python38-3.8.10
===> Checking if python38 is already installed
===> Registering installation for python38-3.8.10
pkg-static: Unable to access file
/tmp/portbuild/usr/ports/lang/python38/work/stage/usr/local/lib/python3.8/lib-d
ynload/_ctypes.cpython-38.so:No
such file or directory
*** Error code 1

The error is probably a result of the previous build error (fatal error:
'ffi.h' file not found):

building '_ctypes' extension
cc -fPIC -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -O2
-pipe -march=sandybridge -fstack-protector-strong -fno-strict-aliasing -std=c99
-Wextra -Wno-unused-result -Wno-unused-parameter
-Wno-missing-field-initializers -Wstrict-prototypes
-Werror=implicit-function-declaration -I./Include/internal -I./Include -I.
-I/usr/local/include
-I/tmp/portbuild/usr/ports/lang/python38/work/Python-3.8.10/Include
-I/tmp/portbuild/usr/ports/lang/python38/work/Python-3.8.10 -c
/tmp/portbuild/usr/ports/lang/python38/work/Python-3.8.10/Modules/_ctypes/_ctyp
es.c
-o
build/temp.freebsd-12.2-RELEASE-p6-amd64-3.8/tmp/portbuild/usr/ports/lang/pytho
n38/work/Python-3.8.10/Modules/_ctypes/_ctypes.o
/tmp/portbuild/usr/ports/lang/python38/work/Python-3.8.10/Modules/_ctypes/_ctyp
es.c:107:10:
fatal error: 'ffi.h' file not found
#include <ffi.h>
^~~~~~~
1 error generated.

Python build finished successfully!

I am using FreeBSD 12.2 on amd64:

# uname -a
FreeBSD portbuild 12.2-RELEASE-p6 FreeBSD 12.2-RELEASE-p6 GENERIC amd64

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256141

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|lang/python38: Fails to |lang/python38: Remove
|install without LIBFFI |LIBFFI option for python*
| |versions which unbundled
| |libffi (Fails to install
| |without LIBFFI)
Status|New |Open
Flags| |merge-quarterly?
Keywords| |easy, needs-patch

--- Comment #1 from Kubilay Kocak <***@FreeBSD.org> ---
Had a couple of reports of this issue. Python unbundled libffi, necessitating
depending on libffi for those versions onward.

The LIBFFI option should be removed across all lang/python* ports where this is
the case, as it is no longer optional

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256141

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Flags|maintainer-feedback?(python |maintainer-feedback+
|@FreeBSD.org) |

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256141

Dmitry Marakasov <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@FreeBSD.org

--- Comment #2 from Dmitry Marakasov <***@FreeBSD.org> ---
Created attachment 225547
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=225547&action=edit
Patch

Proposed patch

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256141

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|lang/python38: Remove |lang/python3*: Remove
|LIBFFI option for python* |LIBFFI option for python*
|versions which unbundled |versions which unbundled
|libffi (Fails to install |libffi (Fails to install
|without LIBFFI) |without LIBFFI)
Keywords|needs-patch |
Assignee|***@FreeBSD.org |***@FreeBSD.org
CC| |***@FreeBSD.org

--- Comment #3 from Kubilay Kocak <***@FreeBSD.org> ---
Thank you Dmitry

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256141

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #225547| |maintainer-approval+
Flags| |

--- Comment #4 from Kubilay Kocak <***@FreeBSD.org> ---
Comment on attachment 225547
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=225547
Patch

Reviewed by: koobs (python)
Approved by: koobs (python)
MFH: 2020Q2 (bugfix)