[Bug 216208] textproc/py-tabletext: configure target fails under py3k with UnicodeDecodeError

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216208

Bug ID: 216208
Summary: textproc/py-tabletext: configure target fails under
py3k with UnicodeDecodeError
Product: Ports & Packages
Version: Latest
Hardware: Any
OS: Any
Status: New
Severity: Affects Only Me
Priority: ---
Component: Individual Port(s)
Assignee: ***@FreeBSD.org
Reporter: ***@saltant.com
CC: ***@FreeBSD.org
Attachment #179022 maintainer-approval?
Flags:
Assignee: ***@FreeBSD.org
Flags: maintainer-feedback?(***@FreeBSD.org)

Created attachment 179022
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=179022&action=edit
textproc/py-tabletext: Specify encoding of files in setup.py

Sample error:

===> Configuring for py34-tabletext-0.1
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "setup.py", line 10, in <module>
+ open("CHANGELOG.rst").read(),
File "/usr/local/lib/python3.4/encodings/ascii.py", line 26, in decode
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 1321:
ordinal not in range(128)
*** Error code 1

I reported this upstream https://github.com/Thibauth/tabletext/issues/1

A fix is attached.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216208

--- Comment #1 from John W. O'Brien <***@saltant.com> ---
The attached patch appears to break the build under python2.

===> Configuring for py27-tabletext-0.1
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "setup.py", line 10, in <module>
+ open("CHANGELOG.rst", encoding='utf8').read(),
TypeError: 'encoding' is an invalid keyword argument for this function
*** Error code 1

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216208

John W. O'Brien <***@saltant.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #179022|0 |1
is obsolete| |
Attachment #179022|maintainer-approval? |
Flags| |
Attachment #179398| |maintainer-approval?
Flags| |

--- Comment #2 from John W. O'Brien <***@saltant.com> ---
Created attachment 179398
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=179398&action=edit
textproc/py-tabletext: Specify encoding of files in setup.py

This version of the patch only passes `encoding` to `open` when built with py3k
or later.

poudriere testport: OK (py2.7, py3.4, py3.5, py3.6)

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216208

Dmitry Sivachenko <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@FreeBSD.org

--- Comment #3 from Dmitry Sivachenko <***@FreeBSD.org> ---
It doesn't look like FreeBSD-specific problem.
Did you submit your patch to the author?

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216208

--- Comment #4 from John W. O'Brien <***@saltant.com> ---
(In reply to Dmitry Sivachenko from comment #3)

I opened a bug [0] but haven't yet submitted the patch.

[0] https://github.com/Thibauth/tabletext/issues/1

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216208

--- Comment #5 from John W. O'Brien <***@saltant.com> ---
(In reply to Dmitry Sivachenko from comment #3)

Submitted pull request [0]

[0] https://github.com/Thibauth/tabletext/pull/2

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216208

Dmitry Sivachenko <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|New |Closed
Resolution|--- |FIXED

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216208

--- Comment #6 from commit-***@freebsd.org ---
A commit references this bug:

Author: demon
Date: Tue Feb 14 17:07:11 UTC 2017
New revision: 434129
URL: https://svnweb.freebsd.org/changeset/ports/434129

Log:
Fix build with python3.x

PR: 216208
Submitted by: John W. O'Brien <***@saltant.com>
maintainer timeout.

Changes:
head/textproc/py-tabletext/files/
head/textproc/py-tabletext/files/patch-setup.py

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216208

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.freebsd.org/bu
| |gzilla/show_bug.cgi?id=2560
| |84