maintainer-approval requested: [Bug 256219] www/py-aiohttp: Update to 3.7.4.post0 : [Attachment 225610] [patch] fix version ordering between 3.7.4 and 3.7.4.post0 (v2)

[b***@freebsd.org]

John Hein <***@liamekaens.com> has asked freebsd-python (Nobody)
<***@FreeBSD.org> for maintainer-approval:
Bug 256219: www/py-aiohttp: Update to 3.7.4.post0
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256219

Attachment 225610: [patch] fix version ordering between 3.7.4 and 3.7.4.post0
(v2)
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=225610&action=edit



--- Comment #21 from John Hein <***@liamekaens.com> ---
Created attachment 225610
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=225610&action=edit
[patch] fix version ordering between 3.7.4 and 3.7.4.post0 (v2)

Fix patch from comment 18 per Charlie Li's observation. The previous patch rev
was missing a change for MASTER_SITES.

I left "p0" because of the portlint whine. It is up to the committer's
discretion whether to ignore portlint and use "post0" in the pkg name instead
(and reflect the upstream distribution name a bit more closely in the PKGNAME).

Next commit to a normal x.y.z should use DISTVERSION, remove DISTNAME and use
the default CHEESESHOP for MASTER_SITES.

Note that upstream is using a pre-release and post-release numbering scheme
that is the opposite of pkg(8) conventions (regarding whether it adds a final
dot before that last part of the version "number"):

pkg(8) - pre: 4.0.0.a0, post: 3.7.4p0 or 3.7.4post0

upstream - pre: 4.0.0a0, post: 3.7.4.post0

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256219

John Hein <***@liamekaens.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #225607|0 |1
is obsolete| |
CC| |***@FreeBSD.org
Attachment #225610| |maintainer-approval?(python
Flags| |@FreeBSD.org)

--- Comment #21 from John Hein <***@liamekaens.com> ---
Created attachment 225610
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=225610&action=edit
[patch] fix version ordering between 3.7.4 and 3.7.4.post0 (v2)

Fix patch from comment 18 per Charlie Li's observation. The previous patch rev
was missing a change for MASTER_SITES.

I left "p0" because of the portlint whine. It is up to the committer's
discretion whether to ignore portlint and use "post0" in the pkg name instead
(and reflect the upstream distribution name a bit more closely in the PKGNAME).

Next commit to a normal x.y.z should use DISTVERSION, remove DISTNAME and use
the default CHEESESHOP for MASTER_SITES.

Note that upstream is using a pre-release and post-release numbering scheme
that is the opposite of pkg(8) conventions (regarding whether it adds a final
dot before that last part of the version "number"):

pkg(8) - pre: 4.0.0.a0, post: 3.7.4p0 or 3.7.4post0

upstream - pre: 4.0.0a0, post: 3.7.4.post0

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256219

--- Comment #22 from John Hein <***@liamekaens.com> ---
(In reply to John Hein from comment #20)
Here's the portlint complaint:

FATAL: Makefile: PORTVERSION looks illegal. You should modify "3.7.4post0".

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256219

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@FreeBSD.org
Flags| |maintainer-feedback?(amdmi3
| |@FreeBSD.org)

--- Comment #23 from Kubilay Kocak <***@FreeBSD.org> ---
(In reply to Charlie Li from comment #19)

If Dmitry can't get to this quickly, happy for you to take it